Thorsten Ball

Results 480 comments of Thorsten Ball

We do have this now: https://github.com/zed-industries/zed/pull/7860 See here for how to set it up: https://github.com/zed-industries/zed/issues/4840#issuecomment-1961282033 What we don't have is what @jaydenseric asked for. @jaydenseric can you create a separate...

Finally got around to documenting it too: https://zed.dev/docs/configuring-zed#code-actions-on-format

Based on the comments above I'd say it's this: ```json "languages": { "JavaScript": { "code_actions_on_format": { "source.fixAll.eslint": true } } } ``` You don't need to set a formatter, since...

Ah, got it. I think the issue here is that `eslint` is not the primary language server. Reopening!

I've got a first fix for eslint-on-format here: https://github.com/zed-industries/zed/pull/8496 @jaydenseric I'll look into your case next, so it's possible to specify the rules that are used when running eslint-fix-on-format. I'm...

Here's the 2nd part that allows you to specify which rules to use when using `code_actions_on_format`: https://github.com/zed-industries/zed/pull/8537 Next step would be that we upgrade to a newer version of `vscode-eslint`.

> @mrnugget It seems like the ESLint fix on save works but is there a way to disable prettier formatting so that the ESLint formatting is saved? Yeah, you can...

Can't you put this in `.zed/settings.json` in your project?

> Can you help me figure out what I'm missing here? Let's find out: 1. Does ESLint fix on format work at all? Meaning: does it fix other things? 2....

@sanketnaik99 interesting! can you create a sample project to reproduce? example file and eslint config etc.?