Thorsten Ball
Thorsten Ball
Hey! What's the exact proposal/request here?
Thanks @0x2CA! That'll help once we get to this.
Hey! Thanks for opening this. I'm not as deep in this topic as you are, so I was wondering whether you think your PR here clashes with what we discussed...
> Already mentioned above. Man, I swear I didn't see the two comments above mine 🤦 Sorry about that! > Looking into "reasons why the zed CLI might report an...
Let's give it a shot!
We landed some other changes in the meantime, can you rebase? Edit: or merge `main` into this!
How do I test this out? With which language server? I tried it with rust-analyzer and it didn't work: https://github.com/user-attachments/assets/666e2c22-1545-44e5-839d-cbf40ec5ae44
> Could we handle the error if range formatting is not supported and show something in the activity indicator or in a notification We have this, which could be used:...
> It seems that activity indicator was broken by `ResultExt::log_err()`, which consumes the error. Are you sure that you add the logging failure to the `last_format_failure` in the `LspStore`? https://github.com/zed-industries/zed/blob/ec5d6e96bb304886f49680b54e58c9b0e7221cd6/crates/project/src/lsp_store.rs#L5106-L5113
Alright! I tried it out locally, using `clangd` (which works), using `rust-analyzer`, using a custom formatter. I think everything works as expected. Good stuff, thank you! I pushed some minor...