Thorsten Ball

Results 480 comments of Thorsten Ball

Hey @timfjord! Sorry for the late response here, but thanks for opening the PR. I watched both videos, but I'm still a bit unsure what exactly is the difference in...

@timfjord I'm not 100% sure myself, but I do think that some of the settings (such as `use_autoclose`) are evaluated each time in the editor and the value on `editor`...

@timfjord I again didn't get to review it today, sorry! I'll try to get to it tomorrow!

I tested this locally, but I can't get it to work. `self.always_treat_brackets_as_autoclosed` in `Editor` is always false for me, no matter what I set in settings. Did you try this...

> Sorry for bombarding you with the messages Don't worry about my notifications :)

Thanks @timfjord! I hopped on the branch and removed two nested conditionals (that were already in the original code, but jumped out to me). Also added an example to the...

> It would be really nice to have a "Right Click > Open in github.com" or similar for lines that have a clear git blame. @ophilli: You can already click...

Just to confirm this: you're running into this when trying to use `gopls`, right? Because no other place uses this method yet.

Got it. I think special-casing `fish` and using `emit fish_prompt` after `cd` isn't that hacky. Why do you think it's hacky? What am I missing?