Markus Dreseler
Markus Dreseler
Thanks to magic_enum, introduced in #2073, this is now unnecessary: ``` const boost::bimap encoding_type_to_string = make_bimap({ {EncodingType::Dictionary, "Dictionary"}, {EncodingType::RunLength, "RunLength"}, {EncodingType::FixedStringDictionary, "FixedStringDictionary"}, {EncodingType::FrameOfReference, "FrameOfReference"}, {EncodingType::LZ4, "LZ4"}, {EncodingType::Unencoded, "Unencoded"}, }); ```...
As discussed in the fortnightly, the PerformanceWarnings have no clear semantics. Who is warned about what? Right now, they look like glorified TODO comments. Remove them and replace them with...
When determining unique constraints, the JoinNode expects the left side of the predicate to belong to the left input. A quick fix would be the following: ```diff diff --git a/src/lib/logical_query_plan/join_node.cpp...
`SegmentAccessor::_segment` is just a reference. In some cases, we seem to create accessors and let the shared_ptr to the segment expire. This can lead to the segment being deleted while...
The basic assumption of the SegmentAccessCounters is that they are fully consumed, i.e., that every iterable value is touched: https://github.com/hyrise/hyrise/blob/09943167c9dbbec99f0829673453c9244ce4108c/src/lib/storage/value_segment/value_segment_iterable.hpp#L34-L35 This is not necessarily the case. If a scan uses...
I just ran into a situation where Hyrise was paged out. This leads to really weird performance results. We can fix it by calling ```cpp mlockall(MCL_CURRENT | MCL_FUTURE); ``` in...
`[ FAILED ] SQLiteTestRunnerUnencoded/SQLiteTestRunner.CompareToSQLite/106, where GetParam() = ("SELECT * FROM id_int_int_int_100 AS t1 LEFT JOIN id_int_int_int_100 AS t2 ON t1.a >= t2.a AND t1.b >= t2.b AND t1.c >= t2.c;",...
This is a temporary issue where I dump things that I will either fix really soon or spin out into actual issues.
In #2294, I almost introduced significant memory costs. I wonder if we should store the Max RSS (getrusage / ru_maxrss, no idea about Mac) in the benchmark JSON and make...