Markus Dreseler

We probably should call lossless_cast to cast the probe column into the index types. Thinking of it, we might want to that for the other join types too. Instead of...

https://github.com/hyrise/hyrise/wiki/Input-Domain-Modeling

Used, e.g., in group_key_index_test.cpp.

Another thought: As of #2000, * `Table::_value_clustered_by` is not forwarded by operators like Projection. * `JoinHash` does not set it, but should be able to set it just like `JoinSortMerge`...

Another one that might be related: `SELECT x+1 FROM (SELECT a AS x FROM t) t2` returns a column `a+1`, not `x+1`. Please open a new issue if this is...

https://github.com/hyrise/hyrise/blob/da63eecf05e9793164c212cdc7ce716a01d4054a/src/lib/sql/sql_translator.cpp#L276 Might be fixable if we either correctly fill `element.identifiers` when using `WITH`, a view, or a subselect or, in case that `element.identifiers.empty()`, traverse the LQP and check for a...

Maybe we even want to put that regex into lint.sh?

@engelfa - if I remember correctly, you mentioned that you were basically done with this? While it might not have brought any performance benefits, we should bring it in anyway.

@engelfa ping?

These look like candidates, too: https://github.com/hyrise/hyrise/blob/da63eecf05e9793164c212cdc7ce716a01d4054a/src/lib/sql/sql_translator.cpp#L603 https://github.com/hyrise/hyrise/blob/da63eecf05e9793164c212cdc7ce716a01d4054a/src/lib/sql/sql_translator.cpp#L671 Edit: No, C++11-style loops are handled correctly.