Mark Klara

Results 44 comments of Mark Klara

Looks like the same issue applies to Breath spells as well.

This shouldn't affect too much though, from the looks of it. The `attackType` is only referenced in `takeDamage` to trigger an event. But no code seems to be listening for...

Would you prefer to leave this value? And, if so, should it be used for BLU breath spells instead of `MAGICAL`? Whatever we decide I can implement it as part...

Understood. I'll leave this PR open then for now. During my audit I'll continue with the existing convention of annotating breath BLU spells as `MAGICAL`. We can always correct them...

Let me know what folks think of this change.

Here's how things look on the xiloader side: https://github.com/mrhappyasthma/xiloader/commit/636050195fbf38fff9e46d5175e22b5e9eddfc7b

Is it as simple as adding some kind of header data on the TCP connection specifying the incoming file size? Or is there significant amounts of work that needs to...

Just updating the save file size 'works'. Although all of the sprites for the SWSH pokemon show as an egg. (Assuming this worked before, perhaps its some issue with data...

Ah okay. Well if sprites are an external issue, looks like we just need to update the `t3x` file. Adding support for versioning and sending/receiving files (with dynamic size) is...

I can't help much with the assets, but i can take a look at the current TCP communication and try to whip up a reasonable protocol to make it a...