Martin Griffin

Results 17 comments of Martin Griffin

It's an improvement in the sense that it catches errors at compile time. Currently you can `GetBoxMonData()` and get some very interesting results. Also, `alias` is a bit confusing, but...

I'm not opposed to them being decimal, I just picked the one I think in (which happens to be hex because so much of the code uses it).

What's your opinion on hex base blocks? I think in some instances they can be quite clean (e.g. if you're deliberately skipping over a screen), but perhaps those should also...

Hopefully we'll be able to get the other languages onto `master` soon and can remove the "used in X language" comments :slightly_smiling_face:

**EDIT: You can ignore this comment, GriffinR and I ended up implementing support for more than 64 TMs+HMs by default** This obviously breaks extended TM/HM learnsets. _But_ it's really easy...

Not 100% sure but I think `include/constants` only uses `#define`s so that it can be imported in `.s`/`.inc` files, so this new `enum` should probably go into `include/pokemon.h` instead? Actually,...

Sorry, this didn't pass. I must have tested on an unclean repo which didn't build everything. I'll fix it ASAP.

I couldn't work out how to make Gimp export grayscale images so `graphics/battle_transitions/rayquaza.png`, `graphics/picture_frame/lobby.png`, and `graphics/battle_transitions/regis.png` are now all indexed.

> Re: discussion in Discord, we might want either a "force" flag / version of `num_tiles`, or make that the default and add some "safe" flag / version that cancels...

You're more than welcome to push changes if you like. I'm away over the weekend, but I could probably get the change done sometime next week if you don't get...