Marco Vitale comments

Results 11 comments of


                                            Marco Vitale

Agent Panel: Claude 3.5 Sonnet not available on free plan

Same issue. Since last week every option that I used before is now requiring the pro subscription, even if I'm logged in on the free plan.

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

> Could you associate this PR with the issue to fix, if any? Done!

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

A couple of quick notes: - This is my first LLVM PR, so if there are any issues with code style or conventions, please let me know! - I'm not...

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

I’ve taken some time to better understand the code and think through the solution. I tried using `isInLifetimeExtendingContext()`, but it still returns false, and I believe I now understand why....

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

> IMO, we have 2 options: > > 1. Add a flag variable into `ExpressionEvaluationContextRecord`. Represent that we are initializing the for-range __range variable. > Eg. > > ```diff >...

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

> > but why can’t we use InLifetimeExtendingContext flag here? > > Is there a subtle difference I’m missing? > > This flag will tiger subroutines to collect `MaterializedTemporaryExpr` and...

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

Old clang tidy test failing seems flaky, locally it pass correctly. If it continue to fail I can rebase on upstream.

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

> There are some test failures in the presubmit checks, you probably need to update these tests. Yes, indeed. For example, in `AST/ast-dump-for-range-lifetime.cpp` we move from: `-MaterializeTemporaryExpr {{.*}} 'C':'P2718R0::C' xvalue...

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

> I think we should revert to the previous approach, what do you think? > > ```c++ > if (IsGslPtrValueFromGslTempOwner && DiagLoc.isValid()) { > if (const auto *VD = >...

[Sema] Fix lifetime extension for temporaries in range-based for loops in C++23

Forgot that the revert wouldn't include the `lifetimebound` attribute. I restructured the switch case like that, in order to catch both: ``` case LK_Extended: { if (!MTE) { // The...