Mr.Chaofan comments

Results 6 comments of


                                            Mr.Chaofan

feat: Add support to callback in protocol interceptor handler without argument to perform as if no interceptors.

> As this is a user-facing API change, we'll need to update API documentation as well as add tests to ensure coverage for this change. Okay. I'll write some tests...

feat: Add support to callback in protocol interceptor handler without argument to perform as if no interceptors.

@codebytere @nornagon I've add some test for protocol.interceptProtocol api. But It is a private api so I don't know how to write document for it. But It is ok to...

feat: Add support to callback in protocol interceptor handler without argument to perform as if no interceptors.

ElectronURLLoaderFactory can be used for protocol intercept and protocol register. There are much differences. If start loading was called by intercept, the receiver is ProxyingURLLoaderFactory, so you can call remote...

feat: Add support to callback in protocol interceptor handler without argument to perform as if no interceptors.

@Imperat I've just updated the document and It seems electron.d.ts was automatically updated too. @codebytere I think it is reasonable to do nothing in the protocol interception handler and just...

fix!: wrong cause and removed flag in cookie change listener

https://github.com/electron/electron/issues/49102

fix!: wrong cause and removed flag in cookie change listener

@codebytere done. I'll fill out PR body next time.