mraszyk

Results 25 comments of mraszyk

Do you intend to also support the built-in `WebAssembly` object: ``` import * as std from 'std' let wasmBuffer = std.loadFile('target/wasm32-unknown-unknown/release/node.wasm'); WebAssembly.instantiate(wasmBuffer).then(wasmModule => { const { add } = wasmModule.instance.exports;...

Will `ic00.canister_status` return log visibility of the canister?

I suppose that logs produced during `install_code` will also be recorded, right?

Why are we ignoring many cases of `HypervisorError` [here](https://github.com/dfinity/ic/blob/8176ea68ae82cb2ba3eec346259e00bf318a171d/rs/embedders/src/wasm_executor.rs#L771)? I also wonder if a trap log message should describe what `ApiType` trapped (in particular, in light of [RUN-957](https://dfinity.atlassian.net/browse/RUN-957)). [RUN-957]: https://dfinity.atlassian.net/browse/RUN-957?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

@ulan There seem to be some mismatches between the spec and the implementation - could you please take a look at my above comments?

Note that if we return 200 for both a pre-execution error and a response certificate, then we should introduce a new enumeration over those two cases.

Could you please CTRL+f for "/call" and update all the places that refer to the async endpoint to make sense in the presence of the new "/sync_call" endpoint?

> I see that for many function calls only `dst` has type `I`, but where it semantically makes sense, should we also have `offset` and `size` also type `I`? Do...

@luc-blaeser Is it important to distinguish between "WebAssembly state" and "WebAssembly memory state"? I saw you suggested inserting "memory" and I wonder why you made the suggestion.

@sasa-tomic Please do not merge until the feature is rolled out in production.