interface-spec icon indicating copy to clipboard operation
interface-spec copied to clipboard
verified publisher icon dfinity

fix: Correct the naming of the trustworthy metric: node num_blocks_total

Open sasa-tomic opened this issue 1 year ago • 6 comments

The current name is confusing not only for me but also for the community member(s). I propose we change it to make it more specific.

image

link: https://matrix.to/#/!jUsknEqNdJobySpXuN:matrix.org/$wmamJVHU4QTXBWvNx-Rbq8NubEfHyAymhfdjMDsrWfU?via=matrix.org&via=greensteps.cn&via=rudd-o.com

sasa-tomic avatar Apr 16 '24 13:04 sasa-tomic

Is this already in production? Then this would be a breaking change.

Dfinity-Bjoern avatar Apr 17 '24 07:04 Dfinity-Bjoern

Is this already in production? Then this would be a breaking change.

@Dfinity-Bjoern correct, but this feature is marked as experimental, so there is no better time to fix it than now (if sensible). Also, the only user of these metrics (that we know of) is the DRE tool.

sasa-tomic avatar Apr 17 '24 11:04 sasa-tomic

You're right, thanks for pointing this out!

Dfinity-Bjoern avatar Apr 23 '24 13:04 Dfinity-Bjoern

@sasa-tomic Please do not merge until the feature is rolled out in production.

mraszyk avatar Apr 23 '24 13:04 mraszyk

The replica code change is in https://gitlab.com/dfinity-lab/public/ic/-/merge_requests/19153

sasa-tomic avatar May 07 '24 14:05 sasa-tomic

This feature is contained in the upcoming IC release so merging this MR now.

mraszyk avatar May 17 '24 16:05 mraszyk