Slava Egorov comments

Results 443 comments of


                                            Slava Egorov

pkg/perf_witness/test/recorder_server_test fails on windows bots

Thanks for looking at this, I already had a fix prepared - just did not land it yet :) https://dart-review.googlesource.com/c/sdk/+/466860

Null safety feedback: How to use firstWhere?

I am going to transfer this to dart-lang/language.

Null safety feedback: How to use firstWhere?

Duplicate of dart-lang/language#836

Null safety feedback: How to use firstWhere?

/cc @leafpetersen @eernstg @lrhn

[vm/aot] Bad code motion with `@pragma('vm:unsafe:no-bounds-checks')`

FWIW we have the same problem with FFI where we are performing aggressive hoisting for accesses through `Pointer`: ``` @pragma('vm:never-inline') int foo(bool v, Pointer p) { var x = 0;...

Socket test sometimes hangs on Mac: standalone/io/raw_server_socket_cancel_test

This test is still skipped in the status files. Should somebody look at this @a-siva ?

[native_assets_builder] Caching strategy for hook invocations

@jtmcdole do you have your benchmark somewhere?

[native_assets_builder] Caching strategy for hook invocations

FWIW with a [simple fix](https://gist.github.com/mraleph/4e7a49dab85da3772a11063e1ce82acb) to the package code XXH3 goes from 8ns/byte on my machine to ~0.6ns/byte in AOT mode. In JIT mode this reveals an ineffecient compilation of...

[native_assets_builder] Caching strategy for hook invocations

@jtmcdole the bulk of the improvement is due to `readLE64` change: avoiding repeated `ByteData.bytelistView` factory call. I think compiler should do a better job removing this allocation but for now...

[native_assets_builder] Caching strategy for hook invocations

> @mraleph - do we want to put up a friendly PR to the xxh3 library? https://github.com/SamJakob/xxh3/pull/4