Slava Egorov

Results 443 comments of Slava Egorov

@rubenferreira97 the syntax you propose is valid today and defines two abstract instance methods.

> Interesting observation. I would say this should go directly into the socket_send implementation. Would it be enough to just call `send` again when EAGAIN occurred, or should `socket_check_fd` also...

Yes, that is correct. I want to keep block based sample buffer for https://dart-review.googlesource.com/c/sdk/+/426220 Furthermore, I have few theories on how this specific race happens. I was planning to take...

@nielsenko There is a code in `_WebSocketImpl._fromSocket` which [responds with a ping if it gets a pong](https://github.com/dart-lang/sdk/blob/d0041273c5800d08167231e3427e2344346e7796/sdk/lib/_http/websocket_impl.dart#L1246-L1247). However this only works if somebody is draining messages... I think this is...

> I think it would make sense to add an implicit listener to respond to ping frames, if the user has not already setup a listener. I thought about it...

Though I still think there is some questions about semantics: what happens with other frames? what happens if we pause processing of incoming data frames? If we think that ping/pong...

These should not be importable using such URIs (e.g. `dart:x/y.dart` is a not a thing that is supposed to work), so they most certainly should be filtered out one way...

@FMorschel we have been reporting paths like this since forever, so I don't think we are too eager to change these.

@aam Quick research shows that we need to set [`LSUIElement`](https://developer.apple.com/documentation/bundleresources/information-property-list/lsuielement?language=objc) to `TRUE` to hide it from Dock. I think this can be done here: ``` _LSApplicationCheckIn(-2, CFBundleGetInfoDictionary(CFBundleGetMainBundle())); ``` We should...

@jmagman I think we should do it once somebody has a moment.