Madhu Rajagopal
Madhu Rajagopal
> Hi @mrajagopal, I want to ask a more general question about what is the intention behind this PR? @jjngx , the objective of this PR is to give test...
> An idea that may be worth considering: > > We have many functions in the `main` that call `log.Fatal` in case of an error. It maybe worth considering to...
> > An idea that may be worth considering: > > We have many functions in the `main` that call `log.Fatal` in case of an error. It maybe worth considering...
So, as a start, would it be fair to say that `main_test.go` should be renamed `flags_test.go` with those tests intended for `main_test.go` moved into such a file?
@vepatel , I have a [PR](https://github.com/nginxinc/kubernetes-ingress/pull/5015) open for the renaming of the file to `flags_test.go`. I reviewed the coverage for `flags.go`: * There are 12 functions in `flags.go` while `flags_test.go`...
* There are 28 functions in `main.go`. * taking `getAndValidateSecret()` as an example, there is k8s [fake Clientset](https://pkg.go.dev/k8s.io/client-go/kubernetes/fake) but this does not match the input to `getAndValidateSecret()` which requires `Cannot...