Chengyu Lin
Chengyu Lin
Is it a better way to first enhance the rust doc? The codebase may need better commentations.
> Good work to kickstart more discussion and refactoring work. 👍 > > One thing I struggle with, is the unclear abstraction of our `trait MT`, should we incline towards...
Done in #120 .
Shall we close this ticket and create a new one for constant time hash to bn254 curve? cc @alxiong @chancharles92
Is there any reference for old discussion about this issue? Also is the gas cost increase going to be significant if we add those domain separators? @alxiong
> > Thanks for finding the notion page. I have a question, so it's probably a good idea to fix "rescue transcript". But is it necessary to also add label...
> > > > Thanks for finding the notion page. I have a question, so it's probably a good idea to fix "rescue transcript". But is it necessary to also...
Also could someone check the CI here? It failed test on my local computer. But CI passed.
> Is it feasible to add a regression test for this? Any suggestion for this? I don't know where to put.
> Not sure. It's kind of a "magic", it's not that obvious that the correct computation is `x / 3 + 1` to the point where we even implemented it...