Anas H. Sulaiman

Results 19 comments of Anas H. Sulaiman

> Heyhey, so you're right it was kind of a breaking change, but only if we consider an earlier bug a "feature" :). 😀 Only our daily clusters are configured...

Sorry for the delay. I'm busy with life atm until the second week of June. I'll try to get back to this issue as soon as I can.

I like the hybrid approach. I think the current approach of not specifying a topic to avoid creating it makes sense. So, for goka's owned topics, we check if they...

Hmm, `Action` seems to be a convenient struct that is used to construct a `Command`: https://github.com/bazelbuild/remote-apis-sdks/blob/d134526aa8874807df0891a7d1eb1e6aa92661ba/go/pkg/client/exec.go#L191-L211 The docker image is, in fact, specified as a platform property on the command...

I see. The request here is to expose the properties to allow clients to add desired ones. I'm happy to review PRs for this. I cannot promise posting one myself,...

@boyan-soubachov I wonder if you can take a look?

@boyan-soubachov thank you for the review. I have updated the code to preserve visible behavior and a added a test case for expected error when a method has been used...

I don't quite understand the issue you're describing. Can you clarify the relationship between the SDK and the k8s pod in your setup? Is the SDK running inside the pod...

Here is what I understood so far: You have a cache server that clears its state when it restarts. Using unified uploads, it's possible for `FindMissingBlobs` to hit the service...

Thanks Doug. This has been working just fine so far and I'm worried about regressions if I change the implementation. I'm considering copying the relevant code over under an "internal"...