Karan Sharma

Results 79 comments of Karan Sharma

> *Docker images are also released with tags {version}-amd64 and {version}-arm64. There is no way to configure goreleaser to solve this problem @arghyadipchak `goreleaser` and `docker` CLI both support this....

@avanier I'll checkout these changes locally and review it by this end of this week.

@avanier Firstly, excellent work so far :) Most of the things are in-place, I just had to do some minor refactoring on how the config is loaded, function/variable naming and...

> It should be in the UI, probably under Performance. config.toml only has config that's required for the app to boot. Okay, @avanier we need to take that in consideration...

> From what I can see in your edits, this would make Prometheus metrics enabled by default. Most applications I've seen always implemented a way to disable metrics altogether. I...

+1 It makes sense for Listmonk to always expose metrics out of the box, as a good default. The current config looks like: ``` # Prometheus Metrics. [metrics] export_process_metrics =...

> a separate goroutine could query the DB for metrics periodically and keep it in a global state somewhere and return on GET /metrics. I am not sure if this...

Yep, that should be possible ^ I'd also add that maybe using https://github.com/VictoriaMetrics/metrics is a better idea than https://github.com/prometheus/client_golang/ because of a much simpler API and a lot less dependencies.

Nice work @avanier and thanks for this! Can you create a PR (Draft is fine too). I am unable to leave comments on the diff link.

@mdehollander Listmonk uses Goreleaser to build and release packages. So, if this has to be done, it should be done via changing the `goreleaser.yml` as mentioned [here](https://goreleaser.com/customization/snapcraft/). That being said,...