Callahan Kovacs

Results 175 comments of Callahan Kovacs

Thanks for the report. I can reproduce this. `argparse` defaults `--enable-manifest` to `SNAPCRAFT_BUILD_INFO` and `--manifest-image-information` to `SNAPCRAFT_IMAGE_INFO`. Later on in the execution, Snapcraft emits the deprecation warning. Snapcraft needs to...

Hi @basak, I think the problem is with the documentation. It doesn't explain the expectations for the environment where Snapcraft can run in destructive mode. Building core20 and older snaps...

1. Checking for root access is a good idea. We have some [precedence for this already](https://github.com/canonical/craft-parts/blob/5b9dffb363c90e77f6e4f448852688251ad5bd70/craft_parts/packages/deb.py#L442). Like you said, some snaps can be built without root permissions, so this could...

The scope of work here is to do this: ```bash snapcraft --destructive-mode Warning: running in destructive mode as non-super user. For more information, see https://snapcraft.io/docs/build-options#p-58836-destructive-mode. ``` with [craft-parts' simple check](https://github.com/canonical/craft-parts/blob/5b9dffb363c90e77f6e4f448852688251ad5bd70/craft_parts/packages/deb.py#L442):...

> @mr-cal @sergiusens Please help with this security scan. I don't know how to fix it. Thanks Hi @ScarlettGatelyMoore, you can ignore the security scan failures for now, it is...

@ScarlettGatelyMoore - the only thing I see is that there is not a test for [these lines](https://github.com/canonical/snapcraft/pull/5092/files#diff-333401a9c3bc7c7c35d0eb9875f579c9daf923fee2ded5948762781d62cc30aeR142-R143): ```python case _: raise AssertionError(f"Unsupported base: {base}") ``` Now, why the code coverage...

There's nothing useful in the log. I'll run it again and see if it fails again.

@ScarlettGatelyMoore - is this ready for review?

I will review this week

> Apologies, just wondering if there's an ETA on when this will be released? It will be in Snapcraft 8.6, which should be on the `candidate` channel by 2024-Jan-20.