Mateusz Pusz

Results 651 comments of Mateusz Pusz

@krofik, I added the `CITATION.cff` file today and now you can find the information on the main project's page: ![image](https://user-images.githubusercontent.com/506260/140304554-1bfd66a8-949f-401a-8807-f6b8321f309e.png) It wasn't that easy for me to create such a...

@krofik, does this address your concerns so we can close this issue?

I am closing this as it seems to be resolved.

Hi, first of all, thanks for the interest in the library and I am really happy that you find it cool 😉 `transfer_rate` in bits is a no-go as IEC8000...

> I think it should always default to B/s. In this particular case maybe it would be a valid solution, but the library is designed in such a way that...

> but it doesn't seem to keep km/h for me @AlanDaniels101 it does not keep km/h because such a unit was never defined in your code. Add ```cpp #include ```...

In this specific case it looks like a nice solution but what about more complicated units? Will the following: ```cpp constexpr auto result = 144 * km / (2 *...

@JohelEGP, is this PR ready to merge (besides merge conflicts)? I thought that you still wanted to add to it.

Hi @TobiasWallner. I generally like your idea. The biggest problem with this approach is a finite precision of a compile-time ratio arithmetics. We already had issues reported for the cases...

Using floating-point for ratio is not an option. We cannot afford even one ULP difference for the same value/ratio because it will not result in the same type/unit.