Mateusz Pusz

Results 651 comments of Mateusz Pusz

> min_width_uint_t can either be implemented... If those features are available on all the [supported compilers](https://mpusz.github.io/mp-units/latest/getting_started/cpp_compiler_support/), then there is no need for alternatives. We always compile with at least C++20.

> The current tests in custom_rep_test_min_impl.cpp do not contain any units conversion Those tests may be cleaned up and refactored if needed. > We may want to refine the interface...

> Whats the preferred way to disable pedantic warnings for a short subsection of code? https://github.com/mpusz/mp-units/blob/2892fd83b0551cd6ccbb63d448b3474e7c1c66b6/src/core/include/mp-units/bits/hacks.h#L42-L43

I pushed some additional tests for `std::complex` usage so you can check your scaling facility with it. I've also added the initial version of the new Representation concepts. Please feel...

C++23 build on clang uses modules. Maybe there is a bug in libc++ that it does not export those types from the `std` module?

I tried as well and I couldn't make it for gcc-12 as well. So I cheated 😜

> what is needed to properly export a name? https://github.com/mpusz/mp-units/blob/master/src/core/include/mp-units/bits/module_macros.h

> Also, I presume `mp-units/bits/scale.h` is anyway the wrong place to export it from, and it should go somewhere into `mp-units/framework/` instead, correct? Yes, `bits/...` are implementation details and should...

Hi @burnpanck, will you have some time to finish the work on your open PRs soon?