Mateusz Pusz

Results 651 comments of Mateusz Pusz

Ahh, I forgot to say that it also requires C++23+ to work 😢 Also, I do not know why a freestanding build failed. FYI, I am providing a 3-day training...

I've just changed the CI scripts (but not the generator) to account for C++23. They should also check for something like `import_std_support` when provided by the matrix.

WOW! You are a true GitHub Actions Wizard! 😄 I would never come up with those solutions by myself. It is great to learn those things from you. Thanks!

Also, it seems that there is some issue with `contracts` setting as it resolves to an empty string instead of "none" here: https://github.com/mpusz/mp-units/actions/runs/11826393072/job/32952538814#step:15:3

Hi @burnpanck, will you have some time to look into it soon?

Sure, it sounds great. However, please be careful with the `import_std` as this requires a very specific configuration and it is enforced through the `conanfile.py`. If `import_std` is set to...

> I also added a [workflow_dispatch](https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_dispatch) trigger to allow Thanks a lot! You are a true GitHub Actions wizard 🧙🏻 I wouldn't know how to do at least half of...

As you have introduced "features" maybe we should also explicitly name [`no_crtp`](https://mpusz.github.io/mp-units/latest/getting_started/cpp_compiler_support/#explicit-this-parameter)? The requirements for it are also provided here: https://github.com/mpusz/mp-units/blob/c1d323a91a44fc19f36e237ed91fc242140759ce/conanfile.py#L114-L122

Thinking a bit more about `workflow_dispatch`, do you think it could be a good idea to be able to manually run the tests for all of the valid possible combinations?...

@burnpanck, you have 5 open PRs. Do you plan to work on those soon? I would like to provide the next mp-units release soon.