Martin Probst

Results 42 comments of Martin Probst

Ack, I can reproduce this. We'll discuss in our bug meeting. Note that `await` has side effects, even when called on an immediate value. I believe it de-schedules the current...

Can you share what compiler options you're using? The repro link you have is using "Simple" optimization flags. In "Simple" mode, unused prototype properties are not removed; you need to...

I see, and I can [reproduce](https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540output_file_name%2520default.js%250A%252F%252F%2520%2540use_closure_library%2520true%250A%252F%252F%2520%2540formatting%2520pretty_print%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT3%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250Agoog.require('goog.math.Coordinate')%253B%250Agoog.require('goog.math.Vec2')%253B%250A%250Avar%2520a%2520%253D%2520new%2520goog.math.Coordinate(4%252C%25207)%253B%250Avar%2520b%2520%253D%2520new%2520goog.math.Vec2(0%252C%2520-1)%253B%250Avar%2520c%2520%253D%2520goog.math.Coordinate.sum(a%252C%2520b)%253B%250Aalert(c)%253B%250A%250A). The compilation result is: ``` /* Copyright The Closure Library Authors. SPDX-License-Identifier: Apache-2.0 */ var c; function d(a, b) { function e() { }...

I think the problem is that gents does not run type checking or type inference at all. That's a conscious choice - you can (could?) only run type checking after...

@filipesilva on Linux, your shell resolves globs for you. E.g. even if you type `echo *`, the `*` is being replaced by your shell interpreter. On Windows, `cmd.exe` does not...

Generally SGTM, one comment: - when there is least one --exclude, or the command is run on windows, node-glob will be used I presume we then just run node-glob to...

My expectation would be that it is very common to have code that's goog.provide()d in a goog.module. All protos and most of the Closure standard library still use goog.provide. OTOH...