Mikaël Pirio

Results 20 comments of Mikaël Pirio

@cibernox I tested with last version 2.2.2: no 'div' is added automatically if we define a `class`.

@cibernox what do you think about this PR? ;) Thanks

- ember-source: 3.12.2 - ember-data: 3.12.6 - ember-data-model-fragments: v4.0.0 I have the same "bug" : make a change in a fragmentArray (add or remove an item), `model.hasDirtyAttributes` is `true` but...

An Ember Twiddle to see the bug: https://ember-twiddle.com/93d84d0a212054ff2a0fc146b27917ae

I have a [fix-issue-330 branch in my repo](https://github.com/mpirio/ember-data-model-fragments/tree/fix-issue-330) but I can not PR to this repo because I need a "release-4.0.0" branch here to PR into it. Thanks.

No news ? I try a new call :) @jakesjews @araddon @cohitre @markhayden. Is it possible to create a "release-4.0.0" branch to PR a [fix about this issue](https://github.com/mpirio/ember-data-model-fragments/tree/fix-issue-330)? Thanks.

Hello @jakesjews. Thanks for your message. > @mpirio were currently in progress moving this repository to ember-adopted-addons #382 Yes I read about adopting this addon. It's a good news. But...

Hello, It seems the migration to adopted has been made. Really good 👍 . Maybe can I give you my fix for this issue? Would it be possible to create...

Hello, Thank you for you message. This PR is for v4.0.0 not 5.0. See https://github.com/mpirio/ember-data-model-fragments/tree/fix-issue-330