Marshall Perrin

This function is working and has been for a while, but it should be added to the documentation before closing this issue.

Hi @rmjarvis, could you please re-file this issue on the spacetelescope repo: https://github.com/spacetelescope/webbpsf That’s our main development repository now and is the best place to file issues. Thanks much for...

The spacetelescope one is the canonical one. This is not a fork since it's older than the spacetelescope one by many years. Would have needed a time machine to fork...

The units issue definitely sounds like a bug. As for applying the phase you want, you’re right there’s a subtle distinction between just applying a phase to a wavefront while...

Ah yes, you can use QuadPhase rather than QuadLens. We could clarify the distinction better in the docs. Sounds like that notebook may need an update too

Examining the log clarifies a bit what is going on. Here's examples of the output log for the two cases of using QuadPhase and QuadraticLens. (Note, I added some additional...

**Aliasing:** Agreed re: doing tests with the same sampling. Note that the minimum recommended value of sampling is 2. (i.e. 2 points per lambda/D, so it's Nyquist sampled). Anything less...

- [ ] add tests for `offset_x`, `offset_y', and`rotation` options to AnalyticOpticalElements. See #7.

Now we have coveralls working again so it's somewhat more user friendly to address this. https://coveralls.io/github/mperrin/poppy The big offender on lacking coverage is the display code, which doesn't get exercised...

I like the idea from that reference of putting together a few end-to-end tests, comparing the results to static pre-generated PNGs, and using a thresholded histogram of the results. I'm...