Marshall Perrin

Results 178 comments of Marshall Perrin

One possible place to put this in the docs would be this page: https://poppy-optics.readthedocs.io/en/latest/options.html But that's still got a great solution. In part because the docs could use a more...

Hi @retroexpress - I just wanted to say, I/we did see this issue report. Apologies but we won't be able to look into it in any detail for some time...

@kjbrooks, could you send me or post here a bit more of the notebook setting up your problem case? In particular the above code samples appear to be using a...

Aha, I didn’t read the above code closely enough. But I think there may be a problem in having the basis variable defined after the get_basis function! Try flipping the...

The default iterations stuff bothers me; I don't know why it needs to be so high. Need to figure out a way to make this a more automatic process, where...

_Refactoring this is definitely something we should leave for 0.4, not right now._ So as currently implemented here's how this works under the hood inside an OpticalSystem and Wavefront: -...

So in https://github.com/mperrin/poppy/pull/55, it looks like you have made the oversampling an attribute of the opticalsystem, rather than something that's specified during the call to calcPSF? Can you explain some...

Right, I was more speaking about how it ought to work, not how it actually worked before. Make it an input to calcPSF, which then gets handed to inputWavefront? Or...

I think all the logic might be able to go on the Wavefront class - all the heavy lifting is done in its various propagation methods rather than the OpticalElements....