Mike Perham
Mike Perham
This is in 8.0.9, you can test it with: ```ruby Sidekiq.configure_server do |cfg| cfg.reap_idle_redis_connections(300) end ``` This will become the default in 8.1.
That first blog post by Arkency is the best practice. Raise the error as normal, tune your error system to ignore the first few occurrences.
I think for the concurrent limiter, it's supposed to track how long the thread was blocked in Redis, waiting for concurrent access. It also depends on your configured `wait_timeout` for...
I was able to see the Waited metrics change as expected: ```ruby class LockedJob include Sidekiq::Job LOCK = Sidekiq::Limiter.concurrent(:erp, 1, wait_timeout: 5) def perform(count) LOCK.within_limit do sleep count end end...
Testing: - [x] Dashboard graphs - [x] RTL languages - [x] Dark/light mode - [x] Pro/Ent support - [ ] Live Polling
RTL looks good enough. Dark mode ❌.
Minor issues with Pro/Ent which I can fix, e.g. rate limiters filtering widget.
Thank you for doing this work. I attempted this upgrade last Spring and it got overwhelming as I'm not good with CSS/styling so this is a huge lift for me.
@markets I appreciate your compatibility concerns. We'll get this into Sidekiq 8.0 so it is part of a major version change. If you want to maintain compatibility with both 7...