Mike Perham

icon indicating a website link https://www.mikeperham.com icon indicating an email [email protected]

icon company Contributed Systems icon location Portland, OR icon location Author and maintainer of Sidekiq, the background job framework for Ruby, and Faktory, background jobs for all languages.

Results 485 comments of Mike Perham

Child batches with enqueued jobs don't prevent parent batches from completing

Show me the actual code. This is too complex to debug with a description.

Child batches with enqueued jobs don't prevent parent batches from completing

Do you have the transactional client enabled? That can delay job push until the batch is no longer in context.

Child batches with enqueued jobs don't prevent parent batches from completing

True, Sidekiq::Client should ignore transactional boundaries when inside the `jobs` block, but bugs and unexpected edge cases always exist.

Child batches with enqueued jobs don't prevent parent batches from completing

Can you reduce it to a reproducible scenario? If you can, I can debug it for you.

Support connection pool reaping for redis

Sidekiq 7 relied on an earlier version of connection_pool. Now that 8 relies on 2.5+, we can make idle reaping an option. Feel free to send a PR if you...

Support connection pool reaping for redis

The only complication is reaping every capsule's pool, not just the main one.

Support connection pool reaping for redis

WDYT? ^^^^^^^^^

Provide easy way to open associated RDoc?

I think rubygems have an rdoc_url element in the gemspec. That could be another piece of the puzzle.

Implement idle redis connection reaping

@jwestbury I smoke tested it but I don't have any way to actually validate the functionality. Would you be able to test the branch in a staging environment and see...

Implement idle redis connection reaping

These changes should apply cleanly to 7.x if you want homework. 😎