Mike Perham

Results 176 comments of Mike Perham

I'd suggest being more aggressive. Why not drop Redis 5? redis-rb 4.x supports Redis 5 just fine, people can continue using it if they don't want to upgrade for some...

I believe that’s code borrowed from Dalli as I never worked on redis-rb back then that I can recall. I’m pretty sure that I chose crc32 because it was easy...

That’s your call but I’m pretty sure crc32 isn’t well suited for either use case.

Yes, I’d love to switch to something like redis-client and lose the redundant mutex. I would also up the minimum Ruby version to 2.7 and clean up any legacy IO...

@casperisfine I love the idea and I would be happy to help with a prototype spike if you want to open an issue or PR against Sidekiq's `7-0` branch. This...

Only redis 6+ interprets it as a double. Earlier versions return an error so this would break compatibility.

I'd love to see: 1. timeout deprecated and replaced with `read_timeout`, the same term as used by Net::HTTP. 2. the README updated to document the timeout options. I will do...

Does it work outside of a multi? Redis takes special care to make MULTI transactional. Do you have any errors in the redis server log?

Yep, I sell closed-source extensions to Sidekiq's open core as my full-time job. The source is actually available (it is normally packaged Ruby code) but not without payment.

> But Rails' ActiveRecord has a reaper that will release connections held by crashed threads, for example, because it's better to be safe than sorry. AFAIK Rails only has this...