Michael Penkov
Michael Penkov
@SagarDollin Are you still interested in working on this?
No, we don't accept PRs on older versions. Can you make one based of the develop head?
@piskvorky What are your thoughts? My opinion is that 4.0 is done and dusted, and any fixes should go to the newest version instead.
Thank you @pabs3 !
Thank you @Witiko !
Just checking up on this PR. It looks like many tests are failing, but it seems that they're unrelated to the changes here. What is left to do here?
No updates on this. Yes, please go ahead.
I think the problem is here: https://github.com/RaRe-Technologies/smart_open/blob/18128f15e50c5ceda065a6d7d041eab6cb0933ad/smart_open/compression.py#L140 We should be making the result of compression_wrapper a context manager too, so it cleans up the underlying stream correctly. Right?
That sounds right. Is tweak_close able to determine when it is being called as part of exception handling? If not, we may have to look at the stack.
Are you able to work out the cause?