Matthias Pigulla comments

Results 320 comments of


                                            Matthias Pigulla

[Translation] Extract locale fallback computation into a dedicated class

There is a possible mistake people might run into when they start using the `FallbackLocaleProvider`: The `Translator` needs to know when the fallback locales are changed in order to reset...

[Translation] Extract locale fallback computation into a dedicated class

Additionally, we might get rid of `getFallbackLocales()` in `DataCollectorTranslator` and `LoggingTranslator` if the `FallbackLocaleProvider` were used directly.

[Translation] Extract locale fallback computation into a dedicated class

I think I need some opinions and/or feedback on this before I can proceed. 👀 🙏🏻

way to combine files before applying filters

If you need the variables in two independent SCSS files, import them in both. IMO this is a problem of your SCSS organization and not a missing feature in Assetic.

Allow to set encoding config for compass filter.

Is there a PR already that makes this configurable in the Symfony2 AsseticBundle?

Allow to set encoding config for compass filter.

@kriswallsmith maybe we could get this even for older Assetic versions? To me it seems that as of OS X 10.9 (Mavericks), compass barks at files containing non-ascii chars. Seems...

Maintain URL state (hash) for more than one tab?

Might be necessary to integrate this with libraries like https://www.npmjs.com/package/hashed (no recommendation, just the first one I came across). /cc @polarbirke

Maintain URL state (hash) for more than one tab?

In case it generates the IDs, are those different if there are multiple instances of the widget on the same page? Will they be the same if I reload the...

Apply stale-while-revalidate also for responses without a validator

_ping_ @Kevinrob

Apply stale-while-revalidate also for responses without a validator

@Kevinrob rebased, waiting for your feedback.