Michel Palourdio

Results 55 comments of Michel Palourdio

Added ability to specify which URLs should trigger loader

Negation is not more a perf. hog that a standard evaluation. Greedy repetitions are much more costly (.*). Just negate the regex of URL for which you want the loader...

CSS box-sizing

please see : https://github.com/zendframework/ZendDeveloperTools/pull/124

CSS box-sizing

I totally agree.

Statically Linked native image does not produce/embed all the needed .so next to the executable

FWIW, `-H:+StaticExecutableWithDynamicLibC` leads to the same error

Usage of dynamic filteredUrlPatterns with async pipe

Indeed, that could be cool, but needs a bit of refactor. Marking as enhancement. Feel free to PR.

Usage of dynamic filteredUrlPatterns with async pipe

Looks sexy, reactive && clean but my main concern is backward compatibility. We need to have a way to not break existing apps that use this lib. As is, BC...

Usage of dynamic filteredUrlPatterns with async pipe

I am an old school boy, I tend to think that every public API should be BC

Add a z-index input property on ng-http-loader component

Thanks for this PR. I'm wondering if we are just not overthinking things here, as it's really easy to do in plain CSS, no ?

Add a z-index input property on ng-http-loader component

Sure, that's why i'm wondering if we should not think about a more universal solution, like giving the ability to specify a custom CSS class, so people consuming this lib...

Add a z-index input property on ng-http-loader component

Take your time to battle test it. And please, let's discuss in another PR.