Add a z-index input property on ng-http-loader component
Add a way to specify a z-index for the component. Default stays 9999.
PS: thanks for this nice package.
Pull Request Test Coverage Report for Build 7196877749
- 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 100.0%
| Totals | |
|---|---|
| Change from base Build 7165466536: | 0.0% |
| Covered Lines: | 89 |
| Relevant Lines: | 89 |
💛 - Coveralls
Thanks for this PR. I'm wondering if we are just not overthinking things here, as it's really easy to do in plain CSS, no ?
This is the actual solution that I had inside my app. However, if the CSS selector changes overtime, the added CSS will fail. Also, maybe I am missing a cleaner way of doing it, but having to add .backdrop application wide (i.e. inside the style.scss of the angular app) may have side effects too
I don't know what the good practice is here
Sure, that's why i'm wondering if we should not think about a more universal solution, like giving the ability to specify a custom CSS class, so people consuming this lib are safer, and have much more css possibilities.With a css class, the selector is directly handled by the dev, and overrides are much simpler
A much better solution! I'll make these changes asap
Take your time to battle test it. And please, let's discuss in another PR.