stellar

stellar copied to clipboard

@hrbrmstr this one's yours. Please! Things to address: 1. Trimming output to screen width 2. Highlighting search terms in output - There's a template [`highlight_phrase` function here](https://github.com/ropenscilabs/flipper/blob/master/R/phrase_to_pkg.R) that you can...

mpadge

Text search complexity vs dependencies

6

I'm not sure how lightweight you want `stellar` to be, but `quanteda` is a fairly heavy dependency, itself bringing in `ggplot2`, various `Rcpp` packages, half the tidyverse, parallel packages, and...

jonocarroll

PAT details

5

The `README` instructions state _"You'll need to check the box for accessing repository data via the github API v4."_ -- I suggest this should be clearer as the settings for...

jonocarroll

Custom class (?)

1

Should the returned object of `getstars` be of a custom class (e.g. `class = "stellar") with its own print method? Perhaps some other methods too (e.g. summary)?

jonocarroll

ORCIDs in author list

2

Could everyone please add their ORCIDs to the `Authors@R` field sometime? These now show up on CRAN. I'm happy to edit them all in myself.

jonocarroll

it works!

4

ahoy @maelle @hrbrmstr @jonocarroll  Basic functionality works - please open issues with any thoughts, desires, suggestions. I'll open a couple already too. And most importantly: Please take what I've...

mpadge

package & function names

3

Package name: 1. `stellar` 2. `ghstar` Function name (current vision is a single, primary function) 1. `ghstar` 2. `stars` Current inclination: ``` stellar::stars() ```

mpadge

Currently just reissues the entire query each time it is run. Would be much better to cache all the stars for each user passed to `stars`, and then just recall...

mpadge