rkv

rkv copied to clipboard

Remove LMDB backend

2

I think we should still keep the migrator for some time. (which then blocks removing lmdb completely)

saschanaz

manage immutable Arc<Rkv> rather than interiorly mutable Arc<RwLock<Rkv>>

10

Manager currently manages `Arc` instances, which enables interior mutability of the Rkv instances. That can result in surprising behavior when fetching a mutated Rkv from the Manager. It also requires...

mykmelez

No details for the LMDB crashes mentioned in the README

7

I've been looking for a rust binding to LMDB and I thought rkv may be a good candidate given it is under mozilla. However, the recommendations in the README for...

serefarikan

After [moving off travis](https://github.com/mozilla/rkv/issues/213) we should add a `cargo audit` run to the CI job.

pjenvey

Have rkv::error::StoreError implement std::error::Error

1

This is a straightforward omission.

rnewman

I imagine that backwards traversal can be done by working directly with the raw cursor but I could not figure how to obtain it. Can someone please provide a code...

jonsecchis

For some reason yet unknown to me we saw empty `data.safe.bin` files for Rkv databases as used inside Firefox by Glean. This causes issues (and crashes) because Rkv bailed out...

badboy

Ensure backwards-compatibility for bincode-serialized data

3

As the "safe-mode" storage uses bincode to serialize the data into a file on disk, there should be some tests that this won't break. rkv needs to be able to...

badboy

Using RKV inside struct implementation

4

The below code fails once it calls commit function. What is it that I am not doing well here. Looks like I am omitting something important ``` pub struct Datastore...

janus

I had been intending at one point to get y'all a PR for this as a way to dip my toes into rkv, which is a cool project. That said,...

thomcc