rkv icon indicating copy to clipboard operation
rkv copied to clipboard

Should an empty file be considered invalid?

Open badboy opened this issue 4 years ago • 0 comments

For some reason yet unknown to me we saw empty data.safe.bin files for Rkv databases as used inside Firefox by Glean. This causes issues (and crashes) because Rkv bailed out and considers an empty file to be invalid (because it can't decode the data).

Our solution is to remove the empty file and try again.

Now the question is if that's something that Rkv should handle directly? An empty file is not really invalid IMO.

(I know Rkv shouldn't create an empty file)

badboy avatar Dec 16 '20 13:12 badboy