Alpha Issiaga DIALLO
Alpha Issiaga DIALLO
> Thanks for explaining the implementation strategy. I still don't under the point of this `dir` argument though. Could you clarify how it helps us deal with conditional dependencies? The...
> I should note that using mutation and global variables is also highly suspicious. We've worked very hard to remove all mutable state in our codebase to make it memoization...
> Where is the association from directory to package is done? I don't see in the code. > > For that matter, I don't see why we need to be...
>First, the UI. It seems that it's a CLI flag to add to build and that will display the missing external libs. How is it intended to be used: just...
>I think I would have expected something a separate command, or a new output in dune describe. I understand that this is less precise: we can't find dependencies of a...
>I don't understand the dir argument either. what does this enable? can we start without this? it seems to me that if we first try to collect all external lib...
To summarize little bit ``` val resolve_name : db -> Lib_name.t -> (Status.t * Kind_db.t) Memo.t ``` With this modification in `Lib.t` and during the crawl on the workspace. We...
@emillon you were right about `Select`, it make sense to know the libraries behind it. It's included in the last changes. Feel free about factorizing the code.
> wonder if this should be a `describe` target rather than a top-level command. I don't get what you mean.
The sub-command `external-lib-deps` is going to move in `describe`. Any suggestion about the spec ?