Volodymyr Agafonkin

Results 529 comments of Volodymyr Agafonkin

> @mourner would you happen to have the original assets for the icons? @jonkoops I'm confused, aren't they the ones in the `src/images` dir? The only SVG that's missing is...

Would this also mean ditching CSS Transitions based zoom animations?

> I'm not sure CSS transitions offer a big performance boost over resetting the CSS transform every animation frame. @IvanSanchez they do, a massive performance boost. At least they did...

I was also thinking whether we could rely on ES6 class syntax for that, e.g. create a `Class` ES6 class and then extending from it with the usual `class Path...

@IvanSanchez I think there's currently a ES proposal for property initialization in the class syntax; there might even be a Rollup/Buble plugin for this, not sure.

Sorry for the trouble with the types! Also heads up that we're holding off on merging a similar change in GL JS because benchmarks show a significant perf regression on...

@HarelM I'm not sure what the root cause is yet β€” maybe you could run some benchmarks (general map rendering performance before/after the upgrades) on your side? Might help track...

> Interestingly enough, this change caused the build size to increase dramatically too. > I'll see if I can spot why... This is likely because of `vt-pbf`, which was not...

I didn't manage to get to the bottom of the regression yet and put the upgrade on hold for now unfortunately (need to work on more urgent issues at the...

@HarelM that one's tricky β€” I wanted to update it but couldn't properly set up all the dev dependencies, e.g. `@mapbox/vtvalidate` seems broken with newer Node versions & the maintainer...