Volodymyr Agafonkin comments

Results 530 comments of


                                            Volodymyr Agafonkin

Calling geojson.updateData multiple times in a short period of time can cause data loss

This should be fixed in the upcoming v3.5.0-beta.1.

Prevent draggable marker touch event propagation

Try this: ```js map.on('touchmove', (e) => e.originalEvent.stopPropagation()); ```

Map#setBearing handles some floats and integers incorrectly

I don't think we should set any guarantees on the bearing/center/zoom numbers being exactly equal since they go through certain math transformations, can change depending on map constraints, etc., so...

Some symbols disappear in globe projection between zoom levels 5 and 6

@karimnaaji looks like this was introduced in #11015 — maybe you have insight into what's going on here?

Generalize current filter function inside search.

Can you expand on this with an example? Not sure I'm following...

Generalize current filter function inside search.

Ah, I see. In theory, the existing `filterFn` semantics can be used for this — e.g. if you return `false` in the function, it won't add the index to the...

Generalize current filter function inside search.

@bryevdv interesting use case, I'll see what I can do! Most likely we can address both this issue and #45 by extending the `filterFn` application — e.g. passing it `index,...

Enhance search if a node is completely inside the query box.

Good call! This would be an equivalent of this change in RBush https://github.com/mourner/rbush/pull/11. It might get a little bit more verbose in Flatbush case, but worth exploring.

Drop UMD and make ESM the default entrypoint

Updated the S3 bucket so that there's no error, but now it complains that there's no `dist` folder to upload. 😅 I think we can just remove the job, and...

Deal with popup that exceeds maxBounds

Yeah, will check this out.