Volodymyr Agafonkin
Volodymyr Agafonkin
I thought we would migrate away from Karma sooner or later anyway — it's a very old project and a pretty stale one. Web Test Runner looks pretty nice.
Tried porting a small part of the tests to Web Test Runner to get a feel for it — looks like it works pretty well overall. Here's the commit: https://github.com/Leaflet/Leaflet/commit/e9a3cf3878e7e18bc1822a8cf9c37d17866e1b48...
@jonkoops started a draft PR here: https://github.com/Leaflet/Leaflet/pull/9242 I also tried Vitest but somehow found it much clunkier and more difficult to get working, at least for this codebase; perhaps this...
@jonkoops love uvu, would be really awesome if we could get it to work with multiple browsers on CI and enough flexibility. The minimalistic approach fits the one from Leafet...
Not currently, that'll probably require a brute force binary search like #25
Yeah, looks like we need to convert Pixelmatch to ESM to use it on the browser properly now. Meanwhile, as a workaround, maybe you could try using Skypack CDN which...
@aemkei hey, I don't have enough bandwidth to look into the mismatches now, but I'd suggest using Meeus for precision. Meeus formulas are known to be more precise than what...
Was this also the case before #7439?
Nice idea! Please add a test for the new behavior and I'll merge. I think it's OK that the parameter is not linear.
Thanks for the suggestion! Perhaps the easiest approach would be to add an optional `maxResults` parameters to `search` (similar to how it works in `neighbors`), and return early when reaching...