Manfred Touron

Results 499 comments of Manfred Touron

I opened this PR (#4926) as an alternative that achieves the goal of the original while maintaining the previous API and ensuring consistency with other calls in this library.

This is the inconsistency I mentioned in your PR. Since you said my PR works as well, I suggest merging mine, which has the highest level of consistency.

GetRaw was an exception. GetString is more similar to other type-based getters. My PR (#4926) implements the necessary changes while maintaining consistency. ~(Edit: currently addressing your comment)~ If you dislike...

The key point is that `GetXXX` / `SetXXX` automatically append the `XXX` type suffix (`.string`, `.int`, etc.) to the key. `GetRaw` / `SetRaw` were an exception not only because they...

Merged #4905 so we can move forward, thank you.

While @notJoon’s point is valid, there’s a distinction. This PR allows for configuring a custom local prefix for a chain whereas #4008 concerns validating an “an” address which could be...

Hey, thank you. @zivkovicmilos: what do you suggest? Anyone: any feedback on how other chains handle this is a manner you prefer?

I suggest we return an `AccountNotFound` error or panic. This is a straightforward issue in `tm2/pkg/sdk/auth` if someone wants to give it a try.

> The issue is the following; you can find only the VM queries in gno.land/pkg/sdk/vm: Yes, that's exactly where I recommend implementing it: directly from this package, instead of from...