Shell icon indicating copy to clipboard operation
Shell copied to clipboard

The Winget package does not reflect what's here in source control

Open stamminator opened this issue 1 year ago • 3 comments

I just installed latest NS fresh on a new machine from Winget, version 1.9.15. I immediately noticed that the dark mode wasn't working, which is an issue that goes back to February. When I go into the imports folder, I notice that theme.nss still has deprecated, broken keywords.

theme
{
	name = "modern"
	dark = sys.dark
	background
	{
		color = default
		opacity = sys.is11 ? default : 90
		effect = default
	}
	image.align = 2
}

What's bizarre about this is that the git blame for this file shows it was fixed far earlier than that, back in version 1.9.10.

I'm getting the feeling that the downloaded packages do not contain the same code we're seeing here on GitHub. For security reasons, this gives me concerns, as it makes me wonder what I'm actually installing.

On a related note, sys.dark still appears in the documentation even though it no longer works.

stamminator avatar Jun 17 '24 16:06 stamminator

Historically, winget has returned the wrong (older) version of applications in the past. If the corresponding package manifest for an application is pointing to/installing the wrong version, calling it to the attention of the winget team directly (by way of GitHub issue in the winget repo) can be effective in resolving such an error.

Not to say that this is the case here -- just throwing it out there in case it might help.

pa-0 avatar Jul 03 '24 05:07 pa-0

@poa00 I just re-reinstalled on a new machine, and this time I installed NS directly from https://nilesoft.org/download/shell/1.9.15/setup.exe. Same result, not winget-specific.

@moudey Can we get some clarification on the state of the new user experience? Shipping with broken syntax in the install files, continuing to host deprecated documentation of the syntax on the website, and requiring the user to dig through GitHub issues for working syntax is a very bad experience that makes me suspect this project is becoming abandonware.

stamminator avatar Jul 10 '24 02:07 stamminator

Hi, There are some issues that have been resolved in the next update coming soon. The documentation needs to be rewritten due to the accumulated amendments and it takes time. I have been very busy for 3 months and there is not enough time for that, but I promise you it will be rewritten and restructured again.

moudey avatar Jul 10 '24 11:07 moudey