Shell icon indicating copy to clipboard operation
Shell copied to clipboard

Missing icons for 'Sort by' & 'Group by' with non-English system language

Open VladWinner opened this issue 3 years ago • 12 comments

image Sort by (English) → Сортировка (Russian) Group by (English) → Группировка (Russian)


Another bug: image Should be Терминал Windows (Russian) instead of ms-resource:AppStoreName and Командная строка (Russian) instead of Command Prompt image


Shell 1.7 Windows 11 22622.575

VladWinner avatar Aug 23 '22 23:08 VladWinner

P.S. I can help translate menu items if you can't fully extract strings from the official localization.

VladWinner avatar Aug 23 '22 23:08 VladWinner

Hi @VladWinner,

Shell uses language resource files used to fetch the titles of menu items for comparison with the current item's title. Presumably those identifiers are constant with any language.

Please attach these files to solve this issue.

windows\ru-RU\explorer.exe.mui
windows\system32\ru-RU\shell32.dll.mui
windows\system32\ru-RU\ExplorerFrame.dll.mui

You can use id.command_prompt.title instead of typing it manually.
More about identifiers https://nilesoft.org/docs/functions/id

moudey avatar Aug 24 '22 01:08 moudey

ru-ru mui.zip

VladWinner avatar Aug 24 '22 03:08 VladWinner

They were found and fixed

shell32.dll.mui/menu/215/28673  "Сор&тировка"
shell32.dll.mui/menu/215/28676  "&Группировка"

Please check other items.

moudey avatar Aug 24 '22 03:08 moudey

Missing icon for 'Rename': image "Rename"→shell32.dll.mui/menu/216/28690 "Пе&реименовать"

Duplicated names and icons (should be 'Share' & 'Send to'): image "Share"→explorerframe.dll.mui/stringtable/3121/49930 "Поделиться" "Send to"→"Отправить как"

Translation for 'Windows Terminal': image "Windows Terminal"→explorer.exe.mui/stringtable/1377/22016 "Терминал Windows"

Other translations: "Copy Path"→shell32.dll.mui/stringtable/1896/30329 "Скопировать путь"


Other (not found) strings:

Full Path→"Полный путь"
Short Path→"Короткий путь"
Parent→"Расположение файла"
Name→"Имя"
Title→"Заголовок"
Extension→"Расширение"
Folder→"Папка"
Folders→"Папки"
Power→"Питание"
Sleep→"Спящий режим"
Hibernate→"Гибернация"
Shut down→"Завершение работы"
Restart→"Перезагрузка"
Apps→"Программы"
Terminal→"Терминал"
`"Note\nHold Shift key to run Terminal as administator"→"Примечание\nУдерживайте Shift для запуска от имени администратора"`

VladWinner avatar Aug 24 '22 12:08 VladWinner

These items have been fixed:

 "Rename"→shell32.dll.mui/menu/216/28690 "Пе&реименовать"
 "Send to"→"Отправить как"

These items already exist:

id.share_with.title
id.share
"Share"→explorerframe.dll.mui/stringtable/3121/49930 "Поделиться"

id.windows_terminal.title
 "Windows Terminal"→explorer.exe.mui/stringtable/1377/22016 "Терминал Windows"

id.copy_path.title
 "Copy Path"→shell32.dll.mui/stringtable/1896/30329 "Скопировать путь"

moudey avatar Aug 24 '22 17:08 moudey

Please test this issue with shell 1.8 beta

moudey avatar Sep 26 '22 18:09 moudey

Sort by/Group by image

Missing icons for 'File Explorer Options' & 'Toggle Attributes' image

Not localized image

Missing icon for 'Open' & 'Open in a new tab' (when select folder) image

'Folders', 'Apps' are also not translated image

VladWinner avatar Sep 26 '22 19:09 VladWinner

'Folders', 'Apps', 'Toggle Attributes' are manual entries

line 316 item(title='Apps' vis=label col)
line 332 menu(title='Folder' image=\uE1F4)

'File Explorer Options' not defined. It will be added later

moudey avatar Sep 26 '22 20:09 moudey

Duplicated names and icons (should be 'Share' & 'Send to'):

image

VladWinner avatar Sep 26 '22 20:09 VladWinner

I think the entries are correct:

"Se&nd to", "О&тправить"
shell32.dll/Menu/223/79

"Share", "Поделиться"
explorerframe.dll/StringTable/3121/49928

moudey avatar Sep 26 '22 21:09 moudey

Maybe Windows 11 specific issue

VladWinner avatar Sep 26 '22 21:09 VladWinner

Hi @VladWinner Please try this bulld

moudey avatar Dec 09 '22 00:12 moudey

Hello @moudey!

Duplicated names and icons (should be 'Share' & 'Send to'):

It's not fixed image

'Folders', 'Apps' are also not translated

I can't test it in this build image default behaviour: image

Missing icon for 'Open' & 'Open in a new tab' (when select folder)

It's not fixed image

Missing icons for 'File Explorer Options'

It's not fixed image

There are also missing icons when select .exe file: "Open file location", "Troubleshoot compatibility", "Pin to Start" image

VladWinner avatar Dec 13 '22 16:12 VladWinner

I think there is a system issue in the "Share" and "Send" items with the same title in the default menu in Russian.

Shell Default

moudey avatar Dec 14 '22 04:12 moudey

Hello @VladWinner Please try this build shell-test.zip

test

moudey avatar Dec 14 '22 14:12 moudey

@moudey This one breaks explorer.exe loading so I can't check further

VladWinner avatar Dec 14 '22 14:12 VladWinner

Please attach shell.log file

moudey avatar Dec 14 '22 14:12 moudey

Nothing special shell.log

VladWinner avatar Dec 14 '22 15:12 VladWinner

Are you using the attached config file?

Just try these settings. It is best to try it on Windows Sandbox

shell
{
	set
	{
		theme.name="modern"
		exclude.where = !process.is_explorer
	}
}

moudey avatar Dec 14 '22 19:12 moudey

Alright, it works but the context menu called by right-click on the taskbar is no longer available. Maybe it has something to do with W11 beta itself.

VladWinner avatar Dec 14 '22 19:12 VladWinner

Shell replaces Taskbar menu with a custom one

Add this code to dynamic section for Taskbar menu

menu(where=@(sys.is11 and this.count == 0) type='taskbar' image=icon.settings expanded=true)
{
   item(title=id.task_manager.title image=\uE159 cmd='taskmgr.exe')
   item(title=id.taskbar_Settings.title sep=both image=inherit cmd='ms-settings:taskbar')
   item(title=id.settings.title image=inherit cmd='ms-settings:')
}

moudey avatar Dec 14 '22 19:12 moudey