Vlad Stan
Vlad Stan
> Whooops i just squashed and merged, i thought it was just merge :O All good! Congrats on the extension!
> max_lnbits_version kind of sounds like the ext still works with this version > > trying to come up with a better name, but I can't think of any good...
> whats so wrong about max version, i think its perfectly fine and describe it exactly - `min_version_...` is the lowest version of LNbits that the extension works on -...
The logical extrapolation is as follows: * `min_version_...` is the lowest version of LNbits that the extension works on * `max_version_...` is the last version of LNbits that the extension...
add to `src/index.jsx`: ```js Maximum LNbits version:{" "} {ext.max_lnbits_version || "0.0.0"} ```
add to `check.py`: ```py self.max_lnbits_version = ext.get("max_lnbits_version") #... max_lnbits_version = config.get("max_lnbits_version") print(f"- max_lnbits_version : {max_lnbits_version}") if max_lnbits_version != self.max_lnbits_version: return ( False, f"max_lnbits_version mismatch: {max_lnbits_version} != {self.max_lnbits_version}", ) ```
Valid request. But low prio atm.
Not planned yet AFAIK. cc: @blackcoffeexbt
Cannot be reproduced. This should have been fixed on the latest version (0.12.8).
Should work as expected in v1.