feat: max_lnbits_version for older releases
- this can help the extension manager to know if the current installed lnbits is compatible with an release.
- this will make it also possible to deprecate unmaintained extension which will break on newer releases
each min_lnbits_version change in the future will mean we have to manually change the max_lnbits_version of the incompatible release aswell, which is fine i think (we already have to change min_version).
this will also help for the 0.13.0 release were every current ext will break. i already added those max version to latest releases upfront in this pr.
new releases will have an max_lnbits_version of 0 or we just remove the key from the json
max_lnbits_version kind of sounds like the ext still works with this version
trying to come up with a better name, but I can't think of any good one, though ...
max_lnbits_version kind of sounds like the ext still works with this version
trying to come up with a better name, but I can't think of any good one, though ...
deprecated_from_lnbits_version?
whats so wrong about max version, i think its perfectly fine and describe it exactly
whats so wrong about max version, i think its perfectly fine and describe it exactly
min_version_...is the lowest version of LNbits that the extension works onmax_version_...is the [@dni fill in the blank please]
whats so wrong about max version, i think its perfectly fine and describe it exactly
* `min_version_...` is the lowest version of LNbits that the extension works on * `max_version_...` is the [@dni fill in the blank please]
its actually the first it does not work. actually the min version of the next release incompat_lnbits_version, not sure
i still would prefer max version every package manager has min and max version so it familiar.
whats so wrong about max version, i think its perfectly fine and describe it exactly
* `min_version_...` is the lowest version of LNbits that the extension works on * `max_version_...` is the first version which will break compatibility and the min version of the following release
The logical extrapolation is as follows:
-
min_version_...is the lowest version of LNbits that the extension works on -
max_version_...is the last version of LNbits that the extension works on
The confusion is clear.
deprecated_from_lnbits_version (or similar) create no confusion.
add to src/index.jsx:
Maximum LNbits version:{" "}
{ext.max_lnbits_version || "0.0.0"}
<br />
add to check.py:
self.max_lnbits_version = ext.get("max_lnbits_version")
#...
max_lnbits_version = config.get("max_lnbits_version")
print(f"- max_lnbits_version : {max_lnbits_version}")
if max_lnbits_version != self.max_lnbits_version:
return (
False,
f"max_lnbits_version mismatch: {max_lnbits_version} != {self.max_lnbits_version}",
)