Moti Zilberman
Moti Zilberman
This is the intended behaviour. I don't foresee it changing unless someone makes a *very* compelling case for a specific thing we can always safely do with partially staged files,...
@Stupidism I'm afraid I can't look into that right now but I'm all for further discussion here.
Thanks for implementing the requested changes! Before merging, we should probably double-check that Node and other bundlers implement the same behaviour, as I don't see any reference to that above...
@acoates-ms I'll merge this, though I'm wary of shipping code we don't fundamentally understand. Can you please help with the followup here? In particular, it's not clear to me what...
Yeah, we're aware of the issue with Chrome not fetching source maps over the network in general. There's a [workaround](https://github.com/facebook/metro/commit/6690b393cc1812af02f8eb20853504f0a6188a83) in inspector-proxy that we're hoping to eventually replace with support...
Can confirm this is still needed on Android JSC (at least as of Expo SDK 47 / React Native 0.70).
Love this and the direction it's evolving in. Some thoughts around future extensibility: What is the modularity story for adding new elements and host APIs (as a user or as...
I see. This functionality would ideally need to interop with `git commit --allow-empty` somehow. I wonder if we can detect this flag in a hook.
@116-7 well spotted! Note that the code for the inspector proxy has moved into the React Native repo. This is where we'd need to fix the routing logic: https://github.com/facebook/react-native/blob/3d5324ad890d426b369184c25784a2ee20cff85d/packages/dev-middleware/src/inspector-proxy/InspectorProxy.js#L97-L100
It looks like Chrome is working on a fix on their side, which might be sufficient as far as old RN releases go: https://chromium-review.googlesource.com/c/chromium/src/+/4942670