metro icon indicating copy to clipboard operation
metro copied to clipboard

Add support for logical assignment operators to metro-react-native-babel-preset

Open frenic opened this issue 3 years ago • 2 comments

This PR adds support for expr1 ??= expr2, expr1 ||= expr2 and expr1 &&= expr2. These are perfectly fine to use with Typescript but it ends up with Unexpected token: operator (?) error with the ??= operator when running with metro-transform-worker.

frenic avatar Jan 28 '22 09:01 frenic

Hi @frenic!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 28 '22 09:01 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jan 28 '22 10:01 facebook-github-bot

Any word on getting this merged?

izakfilmalter avatar Nov 27 '22 14:11 izakfilmalter

Can confirm this is still needed on Android JSC (at least as of Expo SDK 47 / React Native 0.70).

motiz88 avatar Dec 25 '22 15:12 motiz88