Moritz

Results 345 comments of Moritz

> intl: false positive `package:intl` is WIP. I will try to reland the switch to WASM soon. See https://github.com/dart-lang/i18n/pull/822

What about helper files, if my `build.dart` is getting too complex? Should they not be stored in `hooks/src/` or similar?

As this repo has moved to https://github.com/dart-lang/tools/tree/main/pkgs/oauth2, please refile the PR there. Thanks!

As this repo has moved to https://github.com/dart-lang/tools/tree/main/pkgs/oauth2, please refile the PR there. Thanks!

As this repo has moved to https://github.com/dart-lang/tools/tree/main/pkgs/oauth2, please refile the PR there. Thanks!

I18n data means the CLDR data set, which is released twice per year. It introduces changes which will in many cases change the output of functions depending on it. Therefore,...

> If a test doesn't care about the exact output, then it shouldn't be hard coding the string in the expectation, it should instead just use the actual function to...

Yes, checking for some zone variable set by package:test would work, but it would be a bit hacky as it introduces an invisible dependency between the i18n package and `package:test`,...

The zone should rather be ``` T withFormatting(T Function() callback); ``` , as `withoutFormatting` should be the default. But that sounds good! > Looks like another use case for https://github.com/dart-lang/test/issues/377...

> It would be great if this minor change were merged soon. Please refile this PR, as we can't accept contributions without a CLA. Otherwise I will put refiling it...