arb-editor icon indicating copy to clipboard operation
arb-editor copied to clipboard

Allow decimalPatternDigits number format

Open slaci opened this issue 1 year ago • 1 comments
trafficstars

According to https://localizely.com/flutter-arb/ Flutter supports decimalPatternDigits as a number formatter in arb files. However, this plugin does not list that as a valid options in the JSON schema, so a warning with the label "Value is not accepted." is shown in the Problems panel in Vscode when the arb file contains this formatter name.

slaci avatar Feb 21 '24 12:02 slaci

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Feb 21 '24 12:02 google-cla[bot]

It would be great if this minor change were merged soon. The warning when using decimalPatternDigits is so annoying. If not, please suggest a way to suppress this warning. For some reason, adding:

"arbEditor.suppressedWarnings": [
        "all"
    ],

does not work either.

amal-stack avatar Jul 08 '24 11:07 amal-stack

It would be great if this minor change were merged soon.

Please refile this PR, as we can't accept contributions without a CLA. Otherwise I will put refiling it on my to-do list :)

mosuem avatar Jul 08 '24 12:07 mosuem

It would be great if this minor change were merged soon.

Please refile this PR, as we can't accept contributions without a CLA. Otherwise I will put refiling it on my to-do list :)

Hello @mosuem

Please refile this, I'm not planning to sign the CLA for this one line of code.

Thank you,

slaci avatar Jul 08 '24 13:07 slaci

Fixed by #55

mosuem avatar Aug 13 '24 07:08 mosuem