mostafa mahmoud comments

Results 6 comments of


                                            mostafa mahmoud

Refactored to use implicit insert and remove insert_type method from context object #3395

> Looks good, just missing the removal of a few `insert_type` calls Should I only remove the remaining ones, or should I replace them with insert_implicit_type?

Refactored to use implicit insert and remove insert_type method from context object #3395

@dkm can I use clang-format-13 or I must use version 10 because I have some problems in installing version 10

Refactored to use implicit insert and remove insert_type method from context object #3395

> I use version 19, which only very rarely disagrees with version 10. You can always try it with version 13 and see if the CI complains @powerboat9 Thanks! I...

Refactored to use implicit insert and remove insert_type method from context object #3395

> I think you need to fix your sign-off for DCO you are using a pseudonym > > https://gcc.gnu.org/dco.html I changed the sign-off to match the DCO.

Refactored to use implicit insert and remove insert_type method from context object #3395

> > > I think you need to fix your sign-off for DCO you are using a pseudonym > > > https://gcc.gnu.org/dco.html > > > > > > I changed...

Refactored to use implicit insert and remove insert_type method from context object #3395

> Your git signoff line needs to mention your full name it cant be a username Okay, I will use that: Mostafa Mahmoud Younis. But is there any further update...