Moshe Zadka

Just a note that the implementation does not handle the errback case correctly: if any of the deferreds error out, the returned deferred will never fire (instead of firing with...

Let's start from the end -- I totally get that signatures will be replaced by something better. But until I can use something better, they are all I have, and...

Some light feedback: * [_magicValueForParameter](https://github.com/glyph/automat/blob/9b188c58b2c6f41ab7a07216ff96fb1b51b94365/automat/_typical.py#L81) might be a tag *too* magical. For example, what if `beans` has to be lower-cased? `NoBeanHaver.add_beans` would love to lower-case the beans, but it can't...

(For people who read this: this is also a good example of open source contribution workflow: if your contribution is non-trivial, it is often a good idea to open an...

You could have two separate decorators with different `retry_if_exception_type` for that: ```python import tenacity key_retry = tenacity.retry( stop=tenacity.stop_after_attempt(3), retry=tenacity.retry_if_exception_type(KeyError), reraise=True, ) value_retry = tenacity.retry( stop=tenacity.stop_after_attempt(2), retry=tenacity.retry_if_exception_type(ValueError), reraise=True, ) @key_retry @value_retry...

Another option is to have a more explicit immutable builder pattern. But one or the other is probably good. Let me know what you decide!

@sixninetynine Several comments: * I think the right approach is the opposite -- only make public what you *must*, because public APIs are hard to change. If we go with...

@sixninetynine @warsaw any feedback?

I believe that almost nothing here deserves to be a public module. Do we want people doing `from shiv import cli`? Or `from shiv import zipapp`? I don't think we...

cc @warsaw